Re: [PATCH] D23058: [clang-rename] add support for template instantiations

2016-08-03 Thread Kirill Bobyrev via cfe-commits
omtcyfz updated this revision to Diff 66634. https://reviews.llvm.org/D23058 Files: clang-rename/USRFinder.cpp clang-rename/USRFindingAction.cpp test/clang-rename/ComplexFunctionOverride.cpp test/clang-rename/TemplateClassInstantiationFindByDeclaration.cpp test/clang-rename/TemplateClas

Re: [PATCH] D23058: [clang-rename] add support for template instantiations

2016-08-03 Thread Kirill Bobyrev via cfe-commits
omtcyfz added inline comments. Comment at: test/clang-rename/TemplateClassInstantiationFindByDeclaration.cpp:2 @@ -1,3 +1,3 @@ // RUN: cat %s > %t.cpp -// RUN: clang-rename -offset=287 -new-name=Bar %t.cpp -i -- +// RUN: clang-rename -offset=159 -new-name=Bar %t.cpp -i -- // RUN

Re: [PATCH] D23058: [clang-rename] add support for template instantiations

2016-08-03 Thread Kirill Bobyrev via cfe-commits
omtcyfz added inline comments. Comment at: test/clang-rename/TemplateClassInstantiationFindByUninstantiatedType.cpp:2 @@ +1,3 @@ +// RUN: cat %s > %t.cpp +// RUN: clang-rename -offset=440 -new-name=Bar %t.cpp -i -- +// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s al

Re: [PATCH] D23058: [clang-rename] add support for template instantiations

2016-08-02 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: test/clang-rename/TemplateClassInstantiationFindByDeclaration.cpp:2 @@ -1,3 +1,3 @@ // RUN: cat %s > %t.cpp -// RUN: clang-rename -offset=287 -new-name=Bar %t.cpp -i -- +// RUN: