Re: [PATCH] D22931: Add __declspec code_seg support

2016-07-28 Thread Andrew Artz via cfe-commits
kbdsmoke added a comment. Indeed I was incorrect, and I agree with your analysis of the problem @majnemer I'll try to correct this issue in my own time and get some tests going Repository: rL LLVM https://reviews.llvm.org/D22931 ___ cfe-commits

Re: [PATCH] D22931: Add __declspec code_seg support

2016-07-28 Thread David Majnemer via cfe-commits
majnemer added a subscriber: majnemer. majnemer requested changes to this revision. majnemer added a reviewer: majnemer. majnemer added a comment. This revision now requires changes to proceed. Thanks for contributing this! I actually worked on an implementation of this feature but never sent it

Re: [PATCH] D22931: Add __declspec code_seg support

2016-07-28 Thread Reid Kleckner via cfe-commits
rnk added a subscriber: rnk. rnk added a comment. Needs tests, though. The MSDN sample code is probably a good starting point. Comment at: lib/Sema/SemaDeclAttr.cpp:2659 @@ -2658,1 +2658,3 @@ + // code_seg only ever applies to functions. + if (Attr.getName()->getName() == "c