Re: [PATCH] D22919: GCC Compatibility: Support for __final specifier

2016-07-29 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL277134: [GCC] Support for __final specifier (authored by asbokhan). Changed prior to commit: https://reviews.llvm.org/D22919?vs=65951&id=66104#toc Repository: rL LLVM https://reviews.llvm.org/D22919

Re: [PATCH] D22919: GCC Compatibility: Support for __final specifier

2016-07-28 Thread Erich Keane via cfe-commits
erichkeane marked an inline comment as done. erichkeane added a comment. Fixed the braces mentioned. https://reviews.llvm.org/D22919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22919: GCC Compatibility: Support for __final specifier

2016-07-28 Thread Erich Keane via cfe-commits
erichkeane removed rL LLVM as the repository for this revision. erichkeane updated this revision to Diff 65951. https://reviews.llvm.org/D22919 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Parse/Parser.h include/clang/Sema/DeclSpec.h lib/Parse/ParseDeclCXX.cpp lib/Sem

Re: [PATCH] D22919: GCC Compatibility: Support for __final specifier

2016-07-28 Thread David Majnemer via cfe-commits
majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM as-is, clang's behavior would be congruent with GCC's. Comment at: lib/Parse/ParseDeclCXX.cpp:3024-3026 @@ -3013,2 +3023,5 @@ Diag(FinalLoc, diag::ext_ms_seale