Re: [PATCH] D22711: Diagnose invalid failure memory orderings.

2016-08-10 Thread JF Bastien via cfe-commits
jfb added a comment. Warnings look correct. Could they be made more useful by suggesting that `acq_rel` be `acquire` instead, and `release` be `relaxed` instead? https://reviews.llvm.org/D22711 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

Re: [PATCH] D22711: Diagnose invalid failure memory orderings.

2016-08-10 Thread Eric Fiselier via cfe-commits
EricWF added a comment. ping. Clang correctly lowers the invalid memory orders, so do we want these diagnostics? https://reviews.llvm.org/D22711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/