Re: [PATCH] D22622: [analyzer] Add more info to exploded graph dumps

2016-07-24 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL276557: [analyzer] Pring LocationContext in ExplodedGraph dumps. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D22622?vs=65223&id=65267#toc Repository: rL LLVM https://r

Re: [PATCH] D22622: [analyzer] Add more info to exploded graph dumps

2016-07-23 Thread Anna Zaks via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. > Yeah, just since we're all here anyway... By the way, -analyzer-config > prune-paths=false is also very handy. I think you should add these to the checker writer manual in the debuggi

Re: [PATCH] D22622: [analyzer] Add more info to exploded graph dumps

2016-07-23 Thread Artem Dergachev via cfe-commits
NoQ added a comment. > We could add file names but only in cases the file name does not match the > main file. Whoops, right, i guess i'd just fall back to the default source location printing routine for this case (or for macros). F2198462: 3.png > This i

Re: [PATCH] D22622: [analyzer] Add more info to exploded graph dumps

2016-07-23 Thread Artem Dergachev via cfe-commits
NoQ updated this revision to Diff 65223. https://reviews.llvm.org/D22622 Files: lib/StaticAnalyzer/Core/ExprEngine.cpp Index: lib/StaticAnalyzer/Core/ExprEngine.cpp === --- lib/StaticAnalyzer/Core/ExprEngine.cpp +++ lib/StaticAnal

Re: [PATCH] D22622: [analyzer] Add more info to exploded graph dumps

2016-07-22 Thread Anna Zaks via cfe-commits
zaks.anna added a comment. Great! How does this work when a path spans multiple files, specifically, when the definitions from a header file are inlined? We could add file names but only in cases the file name does not match the main file. > and hard to navigate (especially when using a specia

Re: [PATCH] D22622: [analyzer] Add more info to exploded graph dumps

2016-07-21 Thread Artem Dergachev via cfe-commits
NoQ added a comment. Whoops forgot the screenshots: F2187578: 2.png F2187579: 1.png Also not sure how to write tests for these, because we can't choose the directory path for the dump, can we? https://reviews.llvm.org/D2