Re: [PATCH] D22408: [clang-rename] add support for overridden functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL275958: [clang-rename] add support for overridden functions (authored by omtcyfz). Changed prior to commit: https://reviews.llvm.org/D22408?vs=64293&id=64453#toc Repository: rL LLVM https://reviews.

Re: [PATCH] D22408: [clang-rename] add support for overridden functions

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D22408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D22408: [clang-rename] add support for overridden functions

omtcyfz updated this revision to Diff 64293. omtcyfz marked 3 inline comments as done. omtcyfz added a comment. Addressed Manuel's comments. https://reviews.llvm.org/D22408 Files: clang-rename/USRFindingAction.cpp test/clang-rename/VirtualFunctionFindInBaseClass.cpp test/clang-rename/Virt

Re: [PATCH] D22408: [clang-rename] add support for overridden functions

klimek added inline comments. Comment at: clang-rename/USRFindingAction.cpp:45 @@ +44,3 @@ +namespace { +// \brief NamedDeclFindingConsumer should delegate finding USRs relevant to +// given Decl to RelevantUSRFinder. Still pondering whether 'relevant' is a good n

Re: [PATCH] D22408: [clang-rename] add support for overridden functions

omtcyfz marked an inline comment as done. omtcyfz added a comment. https://reviews.llvm.org/D22408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22408: [clang-rename] add support for overridden functions

omtcyfz marked an inline comment as done. Comment at: clang-rename/USRFindingAction.cpp:48 @@ +47,3 @@ +// +// FIXME: It's better to match ctors/dtors via typeLoc's instead of adding +// their USRs to the storage, because we can also match CXXConversionDecl's by T

Re: [PATCH] D22408: [clang-rename] add support for overridden functions

omtcyfz updated this revision to Diff 64285. omtcyfz marked an inline comment as done. omtcyfz added a comment. replaced RecursiveASTVisitor with ASTMatcher https://reviews.llvm.org/D22408 Files: clang-rename/USRFindingAction.cpp test/clang-rename/VirtualFunctionFindInBaseClass.cpp test/c

Re: [PATCH] D22408: [clang-rename] add support for overridden functions

klimek added inline comments. Comment at: clang-rename/USRFindingAction.cpp:12 @@ -12,1 +11,3 @@ +/// \brief Provides an action to find USR for the symbol at and all +/// relevant USRs aswell. /// ... at , as well as all relevant USRs. Comment

Re: [PATCH] D22408: [clang-rename] add support for overridden functions

omtcyfz added inline comments. Comment at: clang-rename/USRFindingAction.cpp:62 @@ +61,3 @@ + bool Found = false; + for (auto &OverriddenMethod : D->overridden_methods()) { +if (std::find(USRs->begin(), USRs->end(), Prazek wrote: > const auto &Ov

Re: [PATCH] D22408: [clang-rename] add support for overridden functions

omtcyfz updated this revision to Diff 64228. omtcyfz marked an inline comment as done. https://reviews.llvm.org/D22408 Files: clang-rename/USRFindingAction.cpp test/clang-rename/VirtualFunctionFindInBaseClass.cpp test/clang-rename/VirtualFunctionFindInDerivedClass.cpp Index: test/clang-ren

Re: [PATCH] D22408: [clang-rename] add support for overridden functions

Prazek added a subscriber: Prazek. Prazek added a comment. haven't found anything else Comment at: clang-rename/USRFindingAction.cpp:62 @@ +61,3 @@ + bool Found = false; + for (auto &OverriddenMethod : D->overridden_methods()) { +if (std::find(USRs->begin(), US