Re: [PATCH] D22285: Support -masm= flag for x86 assembly targets

2016-07-18 Thread Yunzhong Gao via cfe-commits
ygao closed this revision. ygao marked an inline comment as done. ygao added a comment. Closed by https://reviews.llvm.org/rL275877. https://reviews.llvm.org/D22285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

Re: [PATCH] D22285: Support -masm= flag for x86 assembly targets

2016-07-18 Thread Yunzhong Gao via cfe-commits
ygao marked an inline comment as done. Comment at: lib/Driver/Tools.cpp:6379 @@ +6378,3 @@ +void ClangAs::AddX86TargetArgs(const ArgList &Args, +ArgStringList &CmdArgs) const { + if (Arg *A = Args.getLastArg(options::OPT_masm_EQ)) { ---

Re: [PATCH] D22285: Support -masm= flag for x86 assembly targets

2016-07-18 Thread Bruno Cardoso Lopes via cfe-commits
bruno added a subscriber: bruno. bruno accepted this revision. bruno added a reviewer: bruno. bruno added a comment. This revision is now accepted and ready to land. LGTM with one small fix, see below. Comment at: lib/Driver/Tools.cpp:6379 @@ +6378,3 @@ +void ClangAs::AddX86Targ