On 09/10/16 05:27, Stefan Kempf via cfe-commits wrote:
Ed Maste wrote:
emaste added a comment.
Seems fine to me, but I'm not particularly knowledgeable about OpenBSD's
toolchain.
Could you commit it please if it looks ok? This diff is what OpenBSD has
in its tree. We'd like to get it upstrea
Ed Maste wrote:
> emaste added a comment.
>
> Seems fine to me, but I'm not particularly knowledgeable about OpenBSD's
> toolchain.
Could you commit it please if it looks ok? This diff is what OpenBSD has
in its tree. We'd like to get it upstream.
> https://reviews.llvm.org/D22130
>
>
>
__
emaste added a comment.
Seems fine to me, but I'm not particularly knowledgeable about OpenBSD's
toolchain.
https://reviews.llvm.org/D22130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
vsk resigned from this revision.
vsk removed a reviewer: vsk.
vsk added a comment.
I don't see any issues with this patch, but also don't know enough about the
openbsd toolchain to lgtm it.
https://reviews.llvm.org/D22130
___
cfe-commits mailing li
sisnkemp added a comment.
Ping?
https://reviews.llvm.org/D22130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sisnkemp updated this revision to Diff 68046.
sisnkemp added a comment.
Now with test case.
https://reviews.llvm.org/D22130
Files:
lib/Driver/Tools.cpp
test/Driver/openbsd.c
Index: test/Driver/openbsd.c
===
--- test/Driver/ope
joerg added a comment.
This is missing a test case.
https://reviews.llvm.org/D22130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sisnkemp added a comment.
Ping?
https://reviews.llvm.org/D22130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
