Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma

2016-07-15 Thread Kelvin Li via cfe-commits
kkwli0 added a comment. I update the test cases in https://reviews.llvm.org/D22417. Repository: rL LLVM https://reviews.llvm.org/D22096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma

2016-07-15 Thread Kelvin Li via cfe-commits
eviews.llvm.org > >> Cc: cfe-commits@lists.llvm.org; kkw...@gmail.com; cber...@us.ibm.com; > >> sfan...@us.ibm.com; hfin...@anl.gov; acja...@us.ibm.com; Robinson, Paul > >> Subject: Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target > >> parall

Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma

2016-07-14 Thread Alexey Bataev via cfe-commits
...@hotmail.com] >> Sent: Thursday, July 14, 2016 7:51 PM >> To: reviews+d22096+public+4c00789034d62...@reviews.llvm.org >> Cc: cfe-commits@lists.llvm.org; kkw...@gmail.com; cber...@us.ibm.com; >> sfan...@us.ibm.com; hfin...@anl.gov; acja...@us.ibm.com; Robinson, Paul >> S

RE: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma

2016-07-14 Thread Robinson, Paul via cfe-commits
m; hfin...@anl.gov; acja...@us.ibm.com; Robinson, Paul > Subject: Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target > parallel for simd' pragma > > Hi Paul, > Could you provide a little bit more info about diagnostic you see? Maybe > the tests just need to be

Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma

2016-07-14 Thread Alexey Bataev via cfe-commits
Hi Paul, Could you provide a little bit more info about diagnostic you see? Maybe the tests just need to be fixed Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 15.07.2016 2:09, Paul Robinson пишет: > probinson added a subscriber: probinson. > probinson added a c

Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma

2016-07-14 Thread Paul Robinson via cfe-commits
probinson added a subscriber: probinson. probinson added a comment. I'm seeing a different set of diagnostics in two of these tests, because we default to C+11, which makes them fail for us. Ideally you'd conditionalize the tests on the value of `__cplusplus` (like Charles Li has been doing for

Re: [PATCH] D22096: [OpenMP] Sema and parsing for 'target parallel for simd' pragma

2016-07-11 Thread Alexey Bataev via cfe-commits
ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG http://reviews.llvm.org/D22096 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co