Re: [PATCH] D22087: [clang-rename] add basic vim integration

omtcyf0 added a comment. @kimgr oops, sorry. I'll send a cleanup patch. Thanks for noticing. Repository: rL LLVM http://reviews.llvm.org/D22087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

Re: [PATCH] D22087: [clang-rename] add basic vim integration

kimgr added a subscriber: kimgr. kimgr added a comment. I only caught this typo after it was committed. Comment at: clang-tools-extra/trunk/clang-rename/tool/clang-rename.py:17-18 @@ +16,4 @@ +All you have to do now is to place a cursor on a variable/function/class which +you wo

Re: [PATCH] D22087: [clang-rename] add basic vim integration

This revision was automatically updated to reflect the committed changes. Closed by commit rL274759: [clang-rename] add basic vim integration (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D22087?vs=63058&id=63072#toc Repository: rL LLVM http://reviews.llvm.org/D22087

Re: [PATCH] D22087: [clang-rename] add basic vim integration

omtcyf0 added a comment. @bkramer can you please land the patch? http://reviews.llvm.org/D22087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22087: [clang-rename] add basic vim integration

omtcyf0 updated this revision to Diff 63058. http://reviews.llvm.org/D22087 Files: clang-rename/tool/clang-rename.py Index: clang-rename/tool/clang-rename.py === --- /dev/null +++ clang-rename/tool/clang-rename.py @@ -0,0 +1,61 @@

Re: [PATCH] D22087: [clang-rename] add basic vim integration

omtcyf0 updated this revision to Diff 63057. omtcyf0 marked 2 inline comments as done. http://reviews.llvm.org/D22087 Files: clang-rename/tool/clang-rename.py Index: clang-rename/tool/clang-rename.py === --- /dev/null +++ clang-re

Re: [PATCH] D22087: [clang-rename] add basic vim integration

omtcyf0 marked an inline comment as done. Comment at: clang-rename/tool/clang-rename.py:13 @@ +12,3 @@ +map ,cr :pyf /clang-rename.py + +IMPORTANT NOTE: Before running the tool, make sure you saved the file. Aw, sure; sorry for that. That's an artifact from fi

Re: [PATCH] D22087: [clang-rename] add basic vim integration

omtcyf0 marked an inline comment as done. omtcyf0 added a comment. http://reviews.llvm.org/D22087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22087: [clang-rename] add basic vim integration

alexfh added inline comments. Comment at: clang-rename/tool/clang-rename.py:17 @@ +16,3 @@ +All you have to do now is to place a cursor on a variable/function/class which +you would like to rename and press ',cf'. You will be promted a new name if the +cursor points to a valid sym

Re: [PATCH] D22087: [clang-rename] add basic vim integration

alexfh accepted this revision. alexfh added a comment. LG http://reviews.llvm.org/D22087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22087: [clang-rename] add basic vim integration

alexfh added inline comments. Comment at: clang-rename/tool/ClangRename.cpp:39 @@ -38,3 +38,2 @@ #include "llvm/Support/Host.h" -#include #include bkramer wrote: > omtcyf0 wrote: > > bkramer wrote: > > > This looks unrelated. > > Right, but I'm not sure one-li

Re: [PATCH] D22087: [clang-rename] add basic vim integration

alexfh added inline comments. Comment at: clang-rename/tool/clang-rename.py:12 @@ +11,3 @@ + +map ,cf :pyf /clang-include-fixer.py + ioeric wrote: > Maybe a different key binding so that it doesn't conflict with > include-fixer's suggested key binding? `,cr`

Re: [PATCH] D22087: [clang-rename] add basic vim integration

bkramer added inline comments. Comment at: clang-rename/tool/ClangRename.cpp:39 @@ -38,3 +38,2 @@ #include "llvm/Support/Host.h" -#include #include omtcyf0 wrote: > bkramer wrote: > > This looks unrelated. > Right, but I'm not sure one-line patches are welcome

Re: [PATCH] D22087: [clang-rename] add basic vim integration

ioeric added inline comments. Comment at: clang-rename/tool/clang-rename.py:12 @@ +11,3 @@ + +map ,cf :pyf /clang-include-fixer.py + Maybe a different key binding so that it doesn't conflict with include-fixer's suggested key binding? `,cr` for clang-rename m

Re: [PATCH] D22087: [clang-rename] add basic vim integration

omtcyf0 added a comment. Yup. FeelsBadMan. One note about that header removal: how do I do it then? I thought attaching such changes to a random patch is not a problem. Otherwise there will be some one-line patches for such things, won't they? Comment at: clang-rename/tool/Cl

Re: [PATCH] D22087: [clang-rename] add basic vim integration

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. looks good. Still no commit access? ;) http://reviews.llvm.org/D22087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm

Re: [PATCH] D22087: [clang-rename] add basic vim integration

omtcyf0 updated this revision to Diff 63054. omtcyf0 marked 5 inline comments as done. http://reviews.llvm.org/D22087 Files: clang-rename/tool/clang-rename.py Index: clang-rename/tool/clang-rename.py === --- /dev/null +++ clang-re

Re: [PATCH] D22087: [clang-rename] add basic vim integration

bkramer added inline comments. Comment at: clang-rename/tool/ClangRename.cpp:39 @@ -38,3 +38,2 @@ #include "llvm/Support/Host.h" -#include #include This looks unrelated. Comment at: clang-rename/tool/clang-rename.py:14 @@ +13,3 @@ + +All you