rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Thank you again! I've fixed some over-long lines and committed this as r275350.
http://reviews.llvm.org/D21834
___
cfe-commits mailing list
cfe-c
AntonBikineev updated this revision to Diff 63475.
AntonBikineev added a comment.
Moved stars to the right side of declarations
http://reviews.llvm.org/D21834
Files:
include/clang/AST/Stmt.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/AST/ASTImporter.cpp
l
AntonBikineev updated this revision to Diff 63474.
http://reviews.llvm.org/D21834
Files:
include/clang/AST/Stmt.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/AST/ASTImporter.cpp
lib/AST/ExprConstant.cpp
lib/AST/Stmt.cpp
lib/Analysis/BodyFarm.cpp
lib/An
AntonBikineev updated this revision to Diff 63473.
AntonBikineev added a comment.
removed a leftover from parser/cxx1z-init-stmt.cpp test
http://reviews.llvm.org/D21834
Files:
include/clang/AST/Stmt.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/AST/ASTImport
AntonBikineev updated this revision to Diff 63472.
http://reviews.llvm.org/D21834
Files:
include/clang/AST/Stmt.h
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/AST/ASTImporter.cpp
lib/AST/ExprConstant.cpp
lib/AST/Stmt.cpp
lib/Analysis/BodyFarm.cpp
lib/An
AntonBikineev updated the summary for this revision.
AntonBikineev updated this revision to Diff 63471.
AntonBikineev added a comment.
@rsmith,
Richard, again, thank you for guiding. I've addressed your comments.
http://reviews.llvm.org/D21834
Files:
include/clang/AST/Stmt.h
include/clang/B
rsmith added a comment.
This looks really good. Some minor comments then this is ready to commit.
Comment at: include/clang/AST/Stmt.h:890
@@ -889,3 +889,3 @@
IfStmt(const ASTContext &C, SourceLocation IL,
- bool IsConstexpr, VarDecl *var, Expr *cond,
+ bool I
AntonBikineev updated this revision to Diff 63056.
AntonBikineev added a comment.
@rsmith,
I've added some tests for c++1z init statement. Please let me know if there is
anything else I should add or change.
http://reviews.llvm.org/D21834
Files:
include/clang/AST/Stmt.h
include/clang/Sema/
AntonBikineev updated this revision to Diff 62790.
AntonBikineev added a comment.
@rsmith,
Thanks for the comments, I've addressed them (except for tests, they are to be
added asap). I'm especially not sure about changes in CFG.cpp, could you verify
please?
http://reviews.llvm.org/D21834
File
rsmith added a comment.
There are a few missing pieces here:
1. Analysis/CFG.cpp needs to be taught to build a correct CFG for these. You
can test this with an example like 'if (bool b; b)' which should give a
-Wuninitialized warning.
2. AST/ExprConstant.cpp needs to be taught to perform consta
AntonBikineev updated this revision to Diff 62321.
AntonBikineev added a comment.
Test Parser/cxx1z-init-statement.cpp has been updated according to Sema changes
http://reviews.llvm.org/D21834
Files:
include/clang/AST/Stmt.h
include/clang/Sema/Sema.h
lib/AST/ASTImporter.cpp
lib/AST/Stmt
AntonBikineev updated this revision to Diff 62320.
http://reviews.llvm.org/D21834
Files:
include/clang/AST/Stmt.h
include/clang/Sema/Sema.h
lib/AST/ASTImporter.cpp
lib/AST/Stmt.cpp
lib/Analysis/BodyFarm.cpp
lib/CodeGen/CGStmt.cpp
lib/Sema/SemaStmt.cpp
lib/Sema/TreeTransform.h
li
AntonBikineev updated this revision to Diff 62317.
http://reviews.llvm.org/D21834
Files:
include/clang/AST/Stmt.h
include/clang/Sema/Sema.h
lib/AST/ASTImporter.cpp
lib/AST/Stmt.cpp
lib/Analysis/BodyFarm.cpp
lib/CodeGen/CGStmt.cpp
lib/Sema/SemaStmt.cpp
lib/Sema/TreeTransform.h
li
AntonBikineev added a comment.
@rsmith,
> This is not correct; TryParseSimpleDeclaration usually stops long before it
> reaches the end of the simple-declaration, so this will give false negatives
> in lots of cases.
Yes, I noticed that, that's why I changed use of TryParseSimpleDeclaration t
rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.
The proposal has changed since the pre-meeting mailing, and now covers `switch`
as well as `if`. You also need to handle the //expression-statement// form of
//init-statement//.
As
AntonBikineev added a subscriber: cfe-commits.
AntonBikineev updated this revision to Diff 62254.
http://reviews.llvm.org/D21834
Files:
include/clang/AST/Stmt.h
include/clang/Parse/Parser.h
include/clang/Sema/Sema.h
lib/AST/ASTImporter.cpp
lib/AST/Stmt.cpp
lib/Analysis/BodyFarm.cpp
16 matches
Mail list logo
