This revision was automatically updated to reflect the committed changes.
Closed by commit rL277335: Implement tooling::Replacements as a class.
(authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D21748?vs=66294&id=66297#toc
Repository:
rL LLVM
https://reviews.llvm.org/
ioeric updated this revision to Diff 66294.
ioeric added a comment.
- Merge branch 'master' of http://llvm.org/git/clang into replace
https://reviews.llvm.org/D21748
Files:
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refactoring.h
lib/Format/Format.cpp
lib/Format/Sort
ioeric updated this revision to Diff 66093.
ioeric marked an inline comment as done.
ioeric added a comment.
- getShiftedCodePosition: do not minus 1 when there is no replacement text.
https://reviews.llvm.org/D21748
Files:
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refa
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D21748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
ioeric marked an inline comment as done.
Comment at: unittests/Tooling/RefactoringTest.cpp:112
@@ -111,4 +111,3 @@
-TEST_F(ReplacementTest, CanApplyReplacements) {
- FileID ID = Context.createInMemoryFile("input.cpp",
- "line1\nline2\nlin
ioeric updated this revision to Diff 65687.
ioeric added a comment.
- Clean up ReplacemenTest.h header a bit.
https://reviews.llvm.org/D21748
Files:
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refactoring.h
lib/Format/Format.cpp
lib/Format/SortJavaScriptImports.cpp
ioeric updated this revision to Diff 65686.
ioeric added a comment.
- Moved ReplacementTest and toReplacements to ReplacementTest.h
- Merge branch 'master' of http://llvm.org/git/clang into replace
https://reviews.llvm.org/D21748
Files:
include/clang/Tooling/Core/Replacement.h
include/clang
klimek added inline comments.
Comment at: unittests/Tooling/RefactoringTest.cpp:112
@@ -111,4 +111,3 @@
-TEST_F(ReplacementTest, CanApplyReplacements) {
- FileID ID = Context.createInMemoryFile("input.cpp",
- "line1\nline2\nline3\nline4")
ioeric added a comment.
ping :)
https://reviews.llvm.org/D21748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric updated this revision to Diff 64675.
ioeric marked 5 inline comments as done.
ioeric added a comment.
- Addressed review comments.
https://reviews.llvm.org/D21748
Files:
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refactoring.h
lib/Format/Format.cpp
lib/Format/
klimek added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:145
@@ -145,4 +144,3 @@
-/// \brief A set of Replacements.
-/// FIXME: Change to a vector and deduplicate in the RefactoringTool.
-typedef std::set Replacements;
+/// \brief This maintains a set o
ioeric added a comment.
Ping
https://reviews.llvm.org/D21748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric added inline comments.
Comment at: lib/Tooling/Core/Replacement.cpp:300
@@ +299,3 @@
+Replacements Replacements::merge(const Replacement &R) const {
+ Replacements Rs;
+ llvm::consumeError(Rs.add(R));
klimek wrote:
> I'd probably add a single-replacement
ioeric updated this revision to Diff 64016.
ioeric marked 6 inline comments as done.
ioeric added a comment.
- Merge branch 'master' of http://llvm.org/git/clang into replace
- Addressed reviewer's comments.
https://reviews.llvm.org/D21748
Files:
include/clang/Tooling/Core/Replacement.h
inc
klimek added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:160
@@ +159,3 @@
+ /// This returns true if the replacement is successfully inserted; otherwise,
+ /// it returns an llvm::Error, i.e. there is conflict between R and the
+ /// existing replaceme
15 matches
Mail list logo
