Re: [PATCH] D21741: Add test for D21736 and D21737.

2016-06-27 Thread Marcin Koƛcielnicki via cfe-commits
koriakin added a comment. In http://reviews.llvm.org/D21741#467969, @vsk wrote: > Is the plan to commit this along with http://reviews.llvm.org/D21737? Yes, and with http://reviews.llvm.org/D21736+http://reviews.llvm.org/D21739. Repository: rL LLVM http://reviews.llvm.org/D21741 ___

Re: [PATCH] D21741: Add test for D21736 and D21737.

2016-06-27 Thread Vedant Kumar via cfe-commits
vsk added a comment. Is the plan to commit this along with http://reviews.llvm.org/D21737? Comment at: test/Profile/cxx-indirect-call.cpp:3 @@ -2,3 +2,3 @@ -// RUN: %clang_cc1 %s -o - -emit-llvm -fprofile-instrument=clang -mllvm -enable-value-profiling -fexceptions -fcxx-exce

Re: [PATCH] D21741: Add test for D21736 and D21737.

2016-06-27 Thread Marcin Koƛcielnicki via cfe-commits
koriakin added inline comments. Comment at: test/Profile/cxx-indirect-call.cpp:3 @@ -2,3 +2,3 @@ -// RUN: %clang_cc1 %s -o - -emit-llvm -fprofile-instrument=clang -mllvm -enable-value-profiling -fexceptions -fcxx-exceptions -triple %itanium_abi_triple | FileCheck %s +// RUN: %

Re: [PATCH] D21741: Add test for D21736 and D21737.

2016-06-27 Thread Vedant Kumar via cfe-commits
vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. LGTM, with one nit. Comment at: test/Profile/cxx-indirect-call.cpp:3 @@ -2,3 +2,3 @@ -// RUN: %clang_cc1 %s -o - -emit-llvm -fprofile-instrument=clang -mllvm -enable-value-profil