This revision was automatically updated to reflect the committed changes.
Closed by commit rL274628: Include debug info for nested structs and classes
(authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D21705?vs=62283&id=62869#toc
Repository:
rL LLVM
http://reviews.llv
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D21705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
amccarth updated this revision to Diff 62283.
amccarth added a comment.
Applied suggestion from the comments, which eliminates the need to alter the
ObjectiveC test.
http://reviews.llvm.org/D21705
Files:
lib/CodeGen/CGDebugInfo.cpp
lib/CodeGen/CGDebugInfo.h
test/CodeGenCXX/debug-info-dup
amccarth marked 2 inline comments as done.
amccarth added a comment.
http://reviews.llvm.org/D21705
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:1075
@@ +1074,3 @@
+ } else if (const auto *nestedRec = dyn_cast(I)) {
+if (!nestedRec->isImplicit())
+ CollectRecordNestedRecord(nestedRec, elements);
I would add `&& nestedR
