Re: [PATCH] D21675: New ODR checker for modules

2016-08-17 Thread David Blaikie via cfe-commits
dblaikie added inline comments. Comment at: lib/AST/DeclBase.cpp:1810-1812 @@ +1809,5 @@ + void VisitNamedDecl(const NamedDecl *D) { +if (IdentifierInfo *II = D->getIdentifier()) { + ID.AddString(II->getName()); +} +Inherited::VisitNamedDecl(D);

Re: [PATCH] D21675: New ODR checker for modules

2016-08-16 Thread Richard Trieu via cfe-commits
rtrieu updated this revision to Diff 68278. rtrieu added a comment. Add function void ODRHash(llvm::FoldingSetNodeID &ID) to several classes for computing the hash. Decl, Stmt, TemplateArgument, Type and QualType now have this function, and can call among each others' functions. https://revie