Re: [PATCH] D21537: Frontend: Simplify ownership model for clang's output streams.

2016-07-14 Thread Peter Collingbourne via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL275507: Frontend: Simplify ownership model for clang's output streams. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D21537?vs=61317&id=64071#toc Repository: rL LLVM https://r

Re: [PATCH] D21537: Frontend: Simplify ownership model for clang's output streams.

2016-07-14 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Yeah, I think this makes sense on balance, even though it does create a weird situation for the `ASTPrinter` case, where we don't really want to transfer ownership of the stream. ===

Re: [PATCH] D21537: Frontend: Simplify ownership model for clang's output streams.

2016-07-14 Thread Peter Collingbourne via cfe-commits
pcc added a comment. Ping. https://reviews.llvm.org/D21537 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21537: Frontend: Simplify ownership model for clang's output streams.

2016-06-20 Thread Peter Collingbourne via cfe-commits
pcc updated this revision to Diff 61317. pcc added a comment. - Move EmitAssemblyHelper's pass managers into CreatePasses http://reviews.llvm.org/D21537 Files: include/clang/CodeGen/BackendUtil.h include/clang/CodeGen/ObjectFilePCHContainerOperations.h include/clang/Frontend/ASTConsumers.