Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

2016-06-15 Thread Miklos Vajna via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272816: clang-rename: implement renaming of classes with a dtor (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D21364?vs=60801&id=60869#toc Repository: rL LLVM http://review

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

2016-06-15 Thread Manuel Klimek via cfe-commits
klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: clang-rename/USRLocFinder.cpp:94 @@ +93,3 @@ + // that is not to be touched by the rename. + LocationsFound.push_back(DestructorDecl->getLocation().g

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

2016-06-15 Thread Miklos Vajna via cfe-commits
vmiklos updated this revision to Diff 60801. vmiklos added a comment. Now the correct patch. :-) http://reviews.llvm.org/D21364 Files: clang-rename/USRLocFinder.cpp test/clang-rename/DtorDefTest.cpp Index: test/clang-rename/DtorDefTest.cpp ==

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

2016-06-15 Thread Miklos Vajna via cfe-commits
vmiklos updated this revision to Diff 60800. http://reviews.llvm.org/D21364 Files: clang-rename/USRLocFinder.cpp test/clang-rename/DtorDefTest.cpp Index: test/clang-rename/DtorDefTest.cpp === --- /dev/null +++ test/clang-rename/

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

2016-06-15 Thread Miklos Vajna via cfe-commits
vmiklos updated the summary for this revision. vmiklos updated this revision to Diff 60799. http://reviews.llvm.org/D21364 Files: clang-rename/USRLocFinder.cpp test/clang-rename/DtorDefTest.cpp Index: test/clang-rename/DtorDefTest.cpp =

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

2016-06-15 Thread Miklos Vajna via cfe-commits
vmiklos added a comment. Thanks, sounds like exactly what I need. http://reviews.llvm.org/D21364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21364: clang-rename: implement renaming of classes with a dtor

2016-06-15 Thread Manuel Klimek via cfe-commits
klimek added a comment. For 2), SourceLocation has getLocWithOffset? http://reviews.llvm.org/D21364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits