Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

eugenis closed this revision. eugenis added a comment. r272717 Repository: rL LLVM http://reviews.llvm.org/D21317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

eugenis updated this revision to Diff 60759. eugenis added a comment. + docs Repository: rL LLVM http://reviews.llvm.org/D21317 Files: docs/SanitizerCoverage.rst lib/Driver/SanitizerArgs.cpp test/Driver/fsanitize-coverage.c Index: test/Driver/fsanitize-coverage.c =

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

kcc accepted this revision. kcc added a comment. This revision is now accepted and ready to land. LGTM Please also check if the documentation needs to be updated. Repository: rL LLVM http://reviews.llvm.org/D21317 ___ cfe-commits mailing list cfe

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

eugenis added a comment. In http://reviews.llvm.org/D21317#457784, @kcc wrote: > Can you at least add a compiler-rt test where we ensure that this flag can > not be used such that it wil compile but fail to link? > > E.g. > > clang -fsanitize-coverage=edge x.c > > should compile *and* link (a

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

kcc added a comment. Can you at least add a compiler-rt test where we ensure that this flag can not be used such that it wil compile but fail to link? E.g. clang -fsanitize-coverage=edge x.c should compile *and* link (and run) Repository: rL LLVM http://reviews.llvm.org/D21317 _

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

eugenis added a comment. ubsan_standalone (that's what the needsUbsanRt change is for). Repository: rL LLVM http://reviews.llvm.org/D21317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

kcc added a comment. What run-time is going to be linked when coverage is used w/o any of the sanitizers? Repository: rL LLVM http://reviews.llvm.org/D21317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [PATCH] D21317: [sanitizer] Allow sanitize coverage w/o sanitizers.

eugenis added a comment. For the context, this is supposed to fix this problem: https://bugs.chromium.org/p/chromium/issues/detail?id=618534 Of course there are other ways of dealing with that that do not require changing the compiler, but this change seems like the right thing to do. The limit