This revision was automatically updated to reflect the committed changes.
Closed by commit rL274610: Add negative test for TBAA (authored by rogfer01).
Changed prior to commit:
http://reviews.llvm.org/D21295?vs=60667&id=62827#toc
Repository:
rL LLVM
http://reviews.llvm.org/D21295
Files:
c
manmanren added a subscriber: manmanren.
manmanren added a comment.
In http://reviews.llvm.org/D21295#474241, @Anastasia wrote:
> LGTM!
>
> Has this test case been missing from the original commit? If yes, could you
> point to it please! Thanks!
The original commit is the support for tbaa, whe
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM!
Has this test case been missing from the original commit? If yes, could you
point to it please! Thanks!
http://reviews.llvm.org/D21295
rogfer01 added a comment.
Ping?
Thank you very much!
http://reviews.llvm.org/D21295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jmolloy added a comment.
Private reply:
fine by me but a clang person needs to a accept it.
http://reviews.llvm.org/D21295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 added a comment.
Ping? Thank you.
http://reviews.llvm.org/D21295
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rogfer01 updated this revision to Diff 60667.
rogfer01 added a comment.
Much simpler version thanks to @jmolloy comment.
http://reviews.llvm.org/D21295
Files:
test/CodeGen/tbaa.cpp
Index: test/CodeGen/tbaa.cpp
===
--- test/CodeG
rogfer01 added inline comments.
Comment at: test/CodeGen/tbaa.cpp:57
@@ +56,3 @@
+// NO-TBAA-LABEL: define i32 @_Z1g
+// NO-TBAA: store i32 1, i32* %{{.*}}, align 4{{ *$}}
+// NO-TBAA: store i32 4, i32* %{{.*}}, align 4{{ *$}}
jmolloy wrote:
> Would it just be sim
jmolloy added a subscriber: jmolloy.
Comment at: test/CodeGen/tbaa.cpp:57
@@ +56,3 @@
+// NO-TBAA-LABEL: define i32 @_Z1g
+// NO-TBAA: store i32 1, i32* %{{.*}}, align 4{{ *$}}
+// NO-TBAA: store i32 4, i32* %{{.*}}, align 4{{ *$}}
Would it just be simpler to do:
