This revision was automatically updated to reflect the committed changes.
Closed by commit rL272574: clang-rename: implement handling of remaining named
casts (authored by vmiklos).
Changed prior to commit:
http://reviews.llvm.org/D21270?vs=60479&id=60572#toc
Repository:
rL LLVM
http://revi
vmiklos added a comment.
Yes, if there will be a way to avoid hooking into each and every AST callback,
that sounds more effective. :-) I'm aware of one more bug around destructors
when renaming a class, but then I'm (as a user) quite happy about the current
state.
http://reviews.llvm.org/D21
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
LG, although I believe the recent history of changes indicates that the
approach is suboptimal, and we should address this on a higher level. But for
now fixing the bugs seems like the right s