Re: [PATCH] D21268: [x86] translate SSE packed FP comparison builtins to IR

2016-06-15 Thread Sanjay Patel via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL272840: [x86] translate SSE packed FP comparison builtins to IR (authored by spatel). Changed prior to commit: http://reviews.llvm.org/D21268?vs=60473&id=60905#toc Repository: rL LLVM http://reviews

Re: [PATCH] D21268: [x86] translate SSE packed FP comparison builtins to IR

2016-06-13 Thread Simon Pilgrim via cfe-commits
RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D21268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH] D21268: [x86] translate SSE packed FP comparison builtins to IR

2016-06-13 Thread Sanjay Patel via cfe-commits
spatel added a comment. In http://reviews.llvm.org/D21268#455679, @RKSimon wrote: > Eeep that's certainly a lot more work than just adding a few extra cases! > Please add a TODO explaining what we need to do? I don't know what the answer is yet...looks like this is going to require (a lot of)

Re: [PATCH] D21268: [x86] translate SSE packed FP comparison builtins to IR

2016-06-12 Thread Simon Pilgrim via cfe-commits
RKSimon added a comment. Eeep that's certainly a lot more work than just adding a few extra cases! Please add a TODO explaining what we need to do? If there is a problem with the header documentation please can you raise a bugzilla and CC Katya Romanova. http://reviews.llvm.org/D21268

Re: [PATCH] D21268: [x86] translate SSE packed FP comparison builtins to IR

2016-06-12 Thread Sanjay Patel via cfe-commits
spatel added a comment. In http://reviews.llvm.org/D21268#455668, @RKSimon wrote: > Is there any reason that we shouldn't include the avxintrin.h > __builtin_ia32_cmppd/__builtin_ia32_cmpps/__builtin_ia32_cmppd256/__builtin_ia32_cmpps256 > packed intrinsics in this CGBuiltin.cpp patch? Since we

Re: [PATCH] D21268: [x86] translate SSE packed FP comparison builtins to IR

2016-06-12 Thread Simon Pilgrim via cfe-commits
RKSimon added a comment. Is there any reason that we shouldn't include the avxintrin.h __builtin_ia32_cmppd/__builtin_ia32_cmpps/__builtin_ia32_cmppd256/__builtin_ia32_cmpps256 packed intrinsics in this CGBuiltin.cpp patch? Since we're heading towards nixing them anyhow. http://reviews.llvm.o