Re: [PATCH] D21075: Correct invalid end location in diagnostics for some identifiers.

2016-07-06 Thread Manuel Klimek via cfe-commits
klimek added a reviewer: rsmith. Comment at: lib/Sema/SemaType.cpp:1339 @@ +1338,3 @@ +auto R = DS.getSourceRange(); +if (R.getEnd().isInvalid()) + R.setEnd(R.getBegin()); erikjv wrote: > klimek wrote: > > Do you know in which cases we get

Re: [PATCH] D21075: Correct invalid end location in diagnostics for some identifiers.

2016-07-05 Thread Erik Verbruggen via cfe-commits
erikjv added a comment. I'll add tests in the next diff, but I'd like to know if these changes are ok. Comment at: lib/Sema/SemaType.cpp:1339 @@ +1338,3 @@ +auto R = DS.getSourceRange(); +if (R.getEnd().isInvalid()) + R.setEnd(R.getBegin());

Re: [PATCH] D21075: Correct invalid end location in diagnostics for some identifiers.

2016-06-28 Thread Manuel Klimek via cfe-commits
klimek added inline comments. Comment at: lib/Sema/SemaType.cpp:1339 @@ +1338,3 @@ +auto R = DS.getSourceRange(); +if (R.getEnd().isInvalid()) + R.setEnd(R.getBegin()); Do you know in which cases we get source ranges that are half valid?