This revision was automatically updated to reflect the committed changes.
Closed by commit rL271637: [include-fixer] added GNU symbols hardcoded header
mapping. (authored by ioeric).
Changed prior to commit:
http://reviews.llvm.org/D20902?vs=59499&id=59513#toc
Repository:
rL LLVM
http://rev
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lg, thanks!
http://reviews.llvm.org/D20902
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
ioeric updated this revision to Diff 59499.
ioeric added a comment.
- Removed non glibc header mapping.
http://reviews.llvm.org/D20902
Files:
include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp
Index: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp
=
bkramer added a comment.
There are still headers in this list that aren't part of glibc, like curses.
I'd rather have those not in the list right now and add stuff as-needed later.
I hope that other packages usually found in /usr/include are saner so we don't
need to add a header map for them.
ioeric updated this revision to Diff 59411.
ioeric added a comment.
- Addressed reviewer's comment.
http://reviews.llvm.org/D20902
Files:
include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp
Index: include-fixer/find-all-symbols/STLPostfixHeaderMap.cpp
=
bkramer added a comment.
Can we limit this to actual glibc headers, i.e. the output of `dpkg-query -L
libc6-dev` on Debian/Ubuntu? There are some unrelated headers in there, I don't
think we should have them in this list.
http://reviews.llvm.org/D20902
__
