Re: [PATCH] D20874: [libcxx] Two more threading dependencies

2016-06-03 Thread Asiri Rathnayake via cfe-commits
rmaprath updated this revision to Diff 59507. rmaprath added a comment. Added a comment about `~std::thread()` hook. @EricWF: Gentle ping. http://reviews.llvm.org/D20874 Files: include/__threading_support src/thread.cpp Index: src/thread.cpp ===

Re: [PATCH] D20874: [libcxx] Two more threading dependencies

2016-06-02 Thread Ben Craig via cfe-commits
bcraig added inline comments. Comment at: include/__threading_support:187 @@ +186,3 @@ +{ +std::terminate(); +} rmaprath wrote: > bcraig wrote: > > Why does this need to go in threading_support? Seems like this is mostly > > orthogonal to threading. libcxxa

Re: [PATCH] D20874: [libcxx] Two more threading dependencies

2016-06-01 Thread Ben Craig via cfe-commits
bcraig added inline comments. Comment at: include/__threading_support:187 @@ +186,3 @@ +{ +std::terminate(); +} Why does this need to go in threading_support? Seems like this is mostly orthogonal to threading. libcxxabi seems like the better place to hold c