This revision was automatically updated to reflect the committed changes.
Closed by commit rL275261: [PCH] Fix timestamp check on windows hosts.
(authored by pgousseau).
Changed prior to commit:
http://reviews.llvm.org/D20867?vs=59887&id=63794#toc
Repository:
rL LLVM
http://reviews.llvm.org
pgousseau added a comment.
In http://reviews.llvm.org/D20867#482465, @rsmith wrote:
> You have two independent functional changes in this patch: one adds a flag to
> control the emission of timestamps into PCH files, and the other re-enables
> timestamp checking on Win32. Please separate them o
rsmith added a comment.
You have two independent functional changes in this patch: one adds a flag to
control the emission of timestamps into PCH files, and the other re-enables
timestamp checking on Win32. Please separate them out into distinct patches to
be committed separately.
Both parts o
pgousseau added a comment.
Ping!
http://reviews.llvm.org/D20867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pgousseau added a comment.
Ping!
http://reviews.llvm.org/D20867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pgousseau added a comment.
Ping!
http://reviews.llvm.org/D20867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pgousseau added a comment.
Ping!
http://reviews.llvm.org/D20867
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pgousseau added a comment.
> > Are you asking for the 2 seconds tolerance to be part of this patch?
>
> > Or, as it seems the main problem here is the lack of a reproducible, are
> > you ok with the idea of committing this patch first, to see if the
> > inconsistent time stamps is still an i
On 7 Jun 2016 7:52 a.m., "pierre gousseau"
wrote:
>
> pgousseau added a comment.
>
> > > On Linux, if the timestamp of a header file, included in the pch, is
modified, then including the pch without regenerating it causes a fatal
error, which is reasonable.
>
> >
>
> > > On Windows the check is i
It seems Phabricator did not picked up Richard's message so I have manually
copied and replied to it via Phabricator's web interface.
Cheers,
Pierre
On 6 June 2016 at 21:53, Richard Smith wrote:
> On Wed, Jun 1, 2016 at 8:33 AM, pierre gousseau via cfe-commits <
> cfe-commits@lists.llvm.org> w
pgousseau added a comment.
> > On Linux, if the timestamp of a header file, included in the pch, is
> > modified, then including the pch without regenerating it causes a fatal
> > error, which is reasonable.
>
> > On Windows the check is ifdefed out, allowing the compilation to continue
> >
pgousseau updated this revision to Diff 59887.
pgousseau added a comment.
Following Bruno's comment:
- Remove call to sleep using touch -m -a -t
http://reviews.llvm.org/D20867
Files:
include/clang/Driver/CC1Options.td
include/clang/Frontend/FrontendOptions.h
lib/Frontend/CompilerInvocati
On Wed, Jun 1, 2016 at 8:33 AM, pierre gousseau via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> pgousseau created this revision.
> pgousseau added reviewers: rsmith, thakis.
> pgousseau added subscribers: cfe-commits, wristow, probinson, gbedwell,
> bruno, cameron314.
>
> On Linux, if the t
bruno added inline comments.
Comment at: test/PCH/include-timestamp.cpp:8
@@ +7,3 @@
+// RUN: sleep 1
+// RUN: not %clang_cc1 -include-pch %t %s 2>&1 | FileCheck
-check-prefix=CHECK-TIMESTAMP %s
+
pgousseau wrote:
> Without the sleep the test fails for me, as it
pgousseau added inline comments.
Comment at: test/PCH/include-timestamp.cpp:8
@@ +7,3 @@
+// RUN: sleep 1
+// RUN: not %clang_cc1 -include-pch %t %s 2>&1 | FileCheck
-check-prefix=CHECK-TIMESTAMP %s
+
Without the sleep the test fails for me, as it seems the call
pgousseau updated this revision to Diff 59355.
pgousseau added a comment.
Following Bruno's comments:
- Update input files' name to match http://reviews.llvm.org/D20243 review.
- Add llvm-bcanalyzer checks
http://reviews.llvm.org/D20867
Files:
include/clang/Driver/CC1Options.td
include/cla
bruno added inline comments.
Comment at: test/PCH/include-timestamp.cpp:5
@@ +4,3 @@
+// Check timestamp is included by default.
+// RUN: %clang_cc1 -x c++-header -emit-pch -o %t
%S/Inputs/include-timestamp-pch.h
+// RUN: touch %S/Inputs/include-timestamp.h
Can y
17 matches
Mail list logo
