This revision was automatically updated to reflect the committed changes.
Closed by commit rL270998: [mips] Kill 'support' for untested EABI. (authored
by dsanders).
Changed prior to commit:
http://reviews.llvm.org/D20679?vs=58772&id=58782#toc
Repository:
rL LLVM
http://reviews.llvm.org/D20
atanasyan added a comment.
In http://reviews.llvm.org/D20679#442121, @dsanders wrote:
> Just to double-check: Do you still agree we should kill this now that the
> number of tests covering EABI-specific behaviour is non-zero?
>
> I think we should on the basis that we still have no backend tests
dsanders added a comment.
Just to double-check: Do you still agree we should kill this now that the
number of tests covering EABI-specific behaviour is non-zero?
I think we should on the basis that we still have no backend tests and no
buildbots. The only tests we have check that the driver pas
dsanders updated this revision to Diff 58772.
dsanders added a comment.
Herald added subscribers: sdardis, emaste.
Removed the 'eabi' from Tools.cpp this revealed three driver tests for passing
-mabi to the assembler but the ABI itself is still completely untested.
http://reviews.llvm.org/D20679
atanasyan accepted this revision.
atanasyan added a reviewer: atanasyan.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM
Tools.cpp contains the following code. We need to remove `eabi` here too.
if (CPUName.empty()) {
// Deduce CPU name from ABI name.
C
