bcraig closed this revision.
bcraig added a comment.
r270732
http://reviews.llvm.org/D20574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath accepted this revision.
rmaprath added a comment.
This revision is now accepted and ready to land.
LGTM.
(I don't have powers to accept libcxx patches in general, but this patch is
quite small and related to something I plugged in, so, I think it's OK in this
instance)
http://reviews
bcraig marked an inline comment as done.
bcraig added a comment.
http://reviews.llvm.org/D20574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig updated this revision to Diff 58317.
http://reviews.llvm.org/D20574
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++ CMakeLists.txt
@@ -113,6 +113,7 @@
option(LIBCXXABI_ENABLE_WERROR "Fail and stop if
rmaprath added inline comments.
Comment at: CMakeLists.txt:278
@@ -277,1 +277,3 @@
+if (LIBCXXABI_HAS_PTHREAD_API)
+ add_definitions(-D_LIBCPP_HAS_THREAD_API_PTHREAD)
Shouldn't there be an `option()` line for this new build option? Also a check
for compatibili
