Re: [PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

2016-05-18 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. In http://reviews.llvm.org/D20360#432882, @aaron.ballman wrote: > In http://reviews.llvm.org/D20360#432878, @alexfh wrote: > > > In http://reviews.llvm.org/D20360#432874, @aaron.ballman wrote: > > > > > The changes to docs/tools/dump_ast_matchers.py look to be spurious, ca

Re: [PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

2016-05-18 Thread Haojian Wu via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL269916: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr. (authored by hokein). Changed prior to commit: http://reviews.llvm.org/D20360?vs=57600&id=57605#toc Repository: rL LLVM http://revie

Re: [PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

2016-05-18 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 57600. hokein added a comment. Rebase to master. http://reviews.llvm.org/D20360 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMatchersNodeTest.cpp Index

Re: [PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

2016-05-18 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! http://reviews.llvm.org/D20360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

Re: [PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

2016-05-18 Thread Haojian Wu via cfe-commits
hokein added a comment. > ! In http://reviews.llvm.org/D20360#432882, @aaron.ballman wrote: > World executable? That's a bit presumptuous. ;-) 0744 may be fine, but 0755 > does not seem correct to me. > > Regardless, I think that it should be a separate commit, not part of this one > as a d

Re: [PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

2016-05-18 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 57597. hokein added a comment. Remove modification of dump_ast_matchers.py http://reviews.llvm.org/D20360 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTM

Re: [PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

2016-05-18 Thread Haojian Wu via cfe-commits
hokein updated this revision to Diff 57596. hokein marked an inline comment as done. hokein added a comment. Address review comments. http://reviews.llvm.org/D20360 Files: docs/LibASTMatchersReference.html docs/tools/dump_ast_matchers.py include/clang/ASTMatchers/ASTMatchers.h lib/ASTMa

Re: [PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

2016-05-18 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In http://reviews.llvm.org/D20360#432878, @alexfh wrote: > In http://reviews.llvm.org/D20360#432874, @aaron.ballman wrote: > > > The changes to docs/tools/dump_ast_matchers.py look to be spurious, can > > they be reverted? > > > The script should be executable, so

Re: [PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

2016-05-18 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. In http://reviews.llvm.org/D20360#432874, @aaron.ballman wrote: > The changes to docs/tools/dump_ast_matchers.py look to be spurious, can they > be reverted? The script should be executable, so the change looks fine to me. http://reviews.llvm.org/D20360 ___

Re: [PATCH] D20360: [ASTMatcher] Add a node matcher for UnresolvedLookupExpr.

2016-05-18 Thread Aaron Ballman via cfe-commits
aaron.ballman added a subscriber: aaron.ballman. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. The changes to docs/tools/dump_ast_matchers.py look to be spurious, can they be reverted? Comment at: include/clang/ASTMatchers/ASTMatchers.h:1089 @@ -