Re: [PATCH] D20339: Update clang for D20260

pcc added a comment. Thanks, the patch I committed adds `-cl-opt-disable` to the tests. Repository: rL LLVM http://reviews.llvm.org/D20339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

Re: [PATCH] D20339: Update clang for D20260

This revision was automatically updated to reflect the committed changes. Closed by commit rL272710: Update clang for D20348 (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D20339?vs=57527&id=60747#toc Repository: rL LLVM http://reviews.llvm.org/D20339 Files: cfe/trunk

Re: [PATCH] D20339: Update clang for D20260

rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision is now accepted and ready to land. Adding `-cl-opt-disable` to the tests seems fine as an alternative short-term approach; LGTM with that approach (either as part of this change or a separate ch

Re: [PATCH] D20339: Update clang for D20260

pcc added a comment. Ping. http://reviews.llvm.org/D20339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20339: Update clang for D20260

pcc added inline comments. Comment at: test/CodeGenOpenCL/constant-addr-space-globals.cl:3 @@ -2,3 +2,3 @@ -// CHECK: @array = addrspace({{[0-9]+}}) constant +// CHECK: @array = local_unnamed_addr addrspace({{[0-9]+}}) constant __constant float array[2] = {0.0f, 1.0f};

Re: [PATCH] D20339: Update clang for D20260

rsmith added a subscriber: rsmith. Comment at: test/CodeGenOpenCL/constant-addr-space-globals.cl:3 @@ -2,3 +2,3 @@ -// CHECK: @array = addrspace({{[0-9]+}}) constant +// CHECK: @array = local_unnamed_addr addrspace({{[0-9]+}}) constant __constant float array[2] = {0.0f, 1.0f};