Re: [PATCH] D20320: [libunwind] Improve unwinder stack usage - II

2016-05-27 Thread Ben Craig via cfe-commits
bcraig added a comment. In http://reviews.llvm.org/D20320#442246, @rmaprath wrote: > Do you know if there are clang / llvm passes that attempts to achieve some > sort of stack compaction? I couldn't find much. I'm not sure if it belongs to its own pass, or if it is part of another pass, but t

Re: [PATCH] D20320: [libunwind] Improve unwinder stack usage - II

2016-05-27 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL271004: [libunwind] Improve unwinder stack usage - II (authored by asiri). Changed prior to commit: http://reviews.llvm.org/D20320?vs=57452&id=58794#toc Repository: rL LLVM http://reviews.llvm.org/D

Re: [PATCH] D20320: [libunwind] Improve unwinder stack usage - II

2016-05-27 Thread Jonathan Roelofs via cfe-commits
jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. Probably worth doing the same thing for the non-EHABI non-SJLJ implementation, too (that can of course go in a separate commit). LGTM http://reviews.llvm.org/D20320 __

Re: [PATCH] D20320: [libunwind] Improve unwinder stack usage - II

2016-05-27 Thread Asiri Rathnayake via cfe-commits
rmaprath added a comment. In http://reviews.llvm.org/D20320#439368, @bcraig wrote: > LGTM. You probably need to get an approval from someone else though, as I > haven't really established myself in the libunwind code base. > > As a side note... one of these days clang / llvm stack compaction ma

Re: [PATCH] D20320: [libunwind] Improve unwinder stack usage - II

2016-05-25 Thread Ben Craig via cfe-commits
bcraig added a comment. LGTM. You probably need to get an approval from someone else though, as I haven't really established myself in the libunwind code base. As a side note... one of these days clang / llvm stack compaction may actually work reasonably well, and tricks like this won't be nec