Re: [PATCH] D20150: clang-rename: fix renaming of field with implicit initializers

On Thu, May 12, 2016 at 9:22 AM Miklos Vajna wrote: > vmiklos added a comment. > > Hi, > > > Also: should we add a check that the token of the source location we > find actually has the old name? > > > Hmm, how do I get the token at a specific SourceLocation? The best I found > so far is SourceMa

Re: [PATCH] D20150: clang-rename: fix renaming of field with implicit initializers

vmiklos added a comment. Hi, > Also: should we add a check that the token of the source location we find > actually has the old name? Hmm, how do I get the token at a specific SourceLocation? The best I found so far is SourceManager::getBuffer(), but that looks more like looking up raw bytes

Re: [PATCH] D20150: clang-rename: fix renaming of field with implicit initializers

vmiklos added inline comments. Comment at: clang-rename/USRLocFinder.cpp:64 @@ +63,3 @@ + if (Initializer->getSourceOrder() == -1) { +// Ignore implicit initializers. +continue; klimek wrote: > Add a comment like: > // The source location of i

Re: [PATCH] D20150: clang-rename: fix renaming of field with implicit initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rL269161: clang-rename: fix renaming of field with implicit initializers (authored by vmiklos). Changed prior to commit: http://reviews.llvm.org/D20150?vs=56854&id=56859#toc Repository: rL LLVM http:/

Re: [PATCH] D20150: clang-rename: fix renaming of field with implicit initializers

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG Comment at: clang-rename/USRLocFinder.cpp:64 @@ +63,3 @@ + if (Initializer->getSourceOrder() == -1) { +// Ignore implicit initializers. +continue;