thakis added a subscriber: thakis.
thakis accepted this revision.
thakis added a reviewer: thakis.
thakis added a comment.
This revision is now accepted and ready to land.
We use phabricator not very dogmatically. If John says this looks good, then
this looks good, even if phab didn't get the mes
sdefresne added a comment.
Thank you for the comment.
I think my change still needs to be reviewed and approved by someone (at least
in the Phabricator interface it still appears as "Need review"). Can you do the
review and give approval if it looks good to you?
Once this is approved, should I
rjmccall added a comment.
That looks great, thank you.
http://reviews.llvm.org/D20113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdefresne updated this revision to Diff 57924.
sdefresne added a comment.
Ok, this make sense. I've updated my change to follow your recommendation. Can
you take another look?
Using 'extern "C" { ... }" would probably not be an option in my case as I want
to use "ns_consumed" for the parameter
rjmccall added a comment.
In http://reviews.llvm.org/D20113#426884, @sdefresne wrote:
> In http://reviews.llvm.org/D20113#425984, @rjmccall wrote:
>
> > This is a good catch, thanks!
>
>
> Thank you for the quick reply.
>
> Please excuse me if I misunderstood you or if my remark appear off the ma
sdefresne added a comment.
In http://reviews.llvm.org/D20113#425984, @rjmccall wrote:
> This is a good catch, thanks!
Thank you for the quick reply.
Please excuse me if I misunderstood you or if my remark appear off the mark,
this is my first time sending patches to clang. I'm not yet complet
rjmccall added a comment.
This is a good catch, thanks!
As a slight adjustment, It's probably better to just ignore this attribute when
mangling the function type of an entity, the same way that we generally don't
mangle return types because they don't affect overloading. That will require
an
