Re: [PATCH] D20100: [NFC] Header cleanup

2016-07-16 Thread Mehdi AMINI via cfe-commits
mehdi_amini added a comment. Can you rebase? I can't apply it right now. https://reviews.llvm.org/D20100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20100: [NFC] Header cleanup

2016-07-16 Thread Eugene via cfe-commits
kevgs added a comment. Good. I have no commit rights. https://reviews.llvm.org/D20100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20100: [NFC] Header cleanup

2016-07-12 Thread Mehdi AMINI via cfe-commits
mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. Looks like a nice cleanup. http://reviews.llvm.org/D20100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

Re: [PATCH] D20100: [NFC] Header cleanup

2016-05-10 Thread Eugene via cfe-commits
kevgs added a comment. Sadly, I dont know such a tool. I was using a simple script to find unused headers ack --cpp -l 'SmallString\.h"' | xargs grep -L 'SmallString[ (http://reviews.llvm.org/D20100 ___ cfe-commits mailing list cfe-commits@lists.llvm

Re: [PATCH] D20100: [NFC] Header cleanup

2016-05-10 Thread Benjamin Kramer via cfe-commits
bkramer added a subscriber: bkramer. bkramer added a comment. Was this change created by a tool? http://reviews.llvm.org/D20100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits