rengolin closed this revision.
rengolin added a comment.
Committed in r270688.
Repository:
rL LLVM
http://reviews.llvm.org/D20088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
Looks great, thanks Jojo!
Repository:
rL LLVM
http://reviews.llvm.org/D20088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
jojo set the repository for this revision to rL LLVM.
jojo changed the visibility of this Differential Revision from "Public (No
Login Required)" to "All Users".
jojo updated this revision to Diff 58210.
jojo added a comment.
Adjust "getAArch64ArchFeaturesFromMarch" logic.In file lib/Driver/Tools
jojo removed rL LLVM as the repository for this revision.
jojo changed the visibility of this Differential Revision from "All Users" to
"Public (No Login Required)".
jojo updated this revision to Diff 58072.
jojo added a comment.
Remove checkARMArchValid & checkAArch64ArchValid logic.
http://re
jojo added inline comments.
Comment at: lib/Driver/Tools.cpp:707
@@ -696,3 +706,3 @@
std::string MArch = arm::getARMArch(ArchName, Triple);
- if (llvm::ARM::parseArch(MArch) == llvm::ARM::AK_INVALID ||
+ if (!checkARMArchValid(MArch) || llvm::ARM::parseArch(MArch) ==
llvm::A
jojo added a comment.
Dear Bradley,Renato
Sorry for late reply,I have been on leave the last three days.
Thank you very much for your review and suggestons.I will re pondering the
changes.
Repository:
rL LLVM
http://reviews.llvm.org/D20088
___
rengolin added a comment.
In http://reviews.llvm.org/D20088#425589, @rengolin wrote:
> In this case, it may be simpler to just rely on the Triple object that
> already exists in the driver, or just the fact that this is in
> getAArch64ArchFeaturesFromMarch() and pass an extra flag to parseArch(
rengolin added a comment.
Bradley, Jojo,
I'm a bit rusty in that part of the code, but that's not really what I was
thinking either.
The way we started this was to have the TargetParser have *all* parsing. So
both check*ArchValid, if necessary, will have to use the TargetParser to parse
the s
bsmith added inline comments.
Comment at: lib/Driver/Tools.cpp:707
@@ -696,3 +706,3 @@
std::string MArch = arm::getARMArch(ArchName, Triple);
- if (llvm::ARM::parseArch(MArch) == llvm::ARM::AK_INVALID ||
+ if (!checkARMArchValid(MArch) || llvm::ARM::parseArch(MArch) ==
llvm:
