Re: [PATCH] D19960: [scan-build] fix warnings emitted on Clang CodeGen code base

2016-05-09 Thread Apelete Seketeli via cfe-commits
apelete added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1317 @@ -1316,2 +1316,3 @@ } + assert(V && "constant must be not NULL at this point"); TemplateParams.push_back(DBuilder.createTemplateValueParameter( dblaikie wrote: > It lo

Re: [PATCH] D19960: [scan-build] fix warnings emitted on Clang CodeGen code base

2016-05-05 Thread David Blaikie via cfe-commits
dblaikie added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:1317 @@ -1316,2 +1316,3 @@ } + assert(V && "constant must be not NULL at this point"); TemplateParams.push_back(DBuilder.createTemplateValueParameter( It looks like this ass