hubert.reinterpretcast added inline comments.
Comment at: include/llvm/Support/TrailingObjects.h:363
@@ +362,3 @@
+template struct with_counts {
+ enum { Size = totalSizeToAlloc(Counts...) };
+ typedef llvm::AlignedCharArray<
@aaron.ballman; my atte
hubert.reinterpretcast updated this revision to Diff 61844.
hubert.reinterpretcast added a comment.
Reapply r273664 with workaround for MSVC
http://reviews.llvm.org/D19770
Files:
include/llvm/Support/TrailingObjects.h
Index: include/llvm/Support/TrailingObjects.h
hubert.reinterpretcast marked 6 inline comments as done.
hubert.reinterpretcast added a comment.
http://reviews.llvm.org/D19770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL's not at the meeting this week. I'll try to catch someone at the
meeting to see if we can figure out how to get the compiler to squint the
right way at the code first.
-- HT
On Fri, Jun 24, 2016 at 3:47 PM, Aaron Ballman
wrote:
> On Fri, Jun 24, 2016 at 8:25 AM, Aaron Ballman
> wrote:
> >
On Fri, Jun 24, 2016 at 8:25 AM, Aaron Ballman wrote:
> On Fri, Jun 24, 2016 at 8:22 AM, Hubert Tong
> wrote:
>> Working to reverse the patch. I need someone with MSVC to help me.
>
> I'll help out with it when I get a moment (hopefully today or this weekend).
I'm not certain there's a way *to*
On Fri, Jun 24, 2016 at 8:22 AM, Hubert Tong
wrote:
> Working to reverse the patch. I need someone with MSVC to help me.
I'll help out with it when I get a moment (hopefully today or this weekend).
~Aaron
>
> -- HT
>
> On Fri, Jun 24, 2016 at 3:19 PM, Aaron Ballman
> wrote:
>>
>> On Fri, Jun 2
Working to reverse the patch. I need someone with MSVC to help me.
-- HT
On Fri, Jun 24, 2016 at 3:19 PM, Aaron Ballman
wrote:
> On Fri, Jun 24, 2016 at 8:16 AM, Hubert Tong
> wrote:
> > On Fri, Jun 24, 2016 at 3:07 PM, Aaron Ballman
> > wrote:
> >>
> >> On Fri, Jun 24, 2016 at 8:05 AM, Huber
On Fri, Jun 24, 2016 at 8:16 AM, Hubert Tong
wrote:
> On Fri, Jun 24, 2016 at 3:07 PM, Aaron Ballman
> wrote:
>>
>> On Fri, Jun 24, 2016 at 8:05 AM, Hubert Tong
>> wrote:
>> > On Fri, Jun 24, 2016 at 3:00 PM, Aaron Ballman
>> > wrote:
>> >>
>> >> aaron.ballman added a comment.
>> >>
>> >> Did R
On Fri, Jun 24, 2016 at 3:07 PM, Aaron Ballman
wrote:
> On Fri, Jun 24, 2016 at 8:05 AM, Hubert Tong
> wrote:
> > On Fri, Jun 24, 2016 at 3:00 PM, Aaron Ballman
> > wrote:
> >>
> >> aaron.ballman added a comment.
> >>
> >> Did Richard sign off on this off-line? Also, this has caused a bot
> >>
On Fri, Jun 24, 2016 at 8:05 AM, Hubert Tong
wrote:
> On Fri, Jun 24, 2016 at 3:00 PM, Aaron Ballman
> wrote:
>>
>> aaron.ballman added a comment.
>>
>> Did Richard sign off on this off-line? Also, this has caused a bot
>> failure:
>
> That was my understanding.
Ah, I meant, "I approve this, but
On Fri, Jun 24, 2016 at 3:00 PM, Aaron Ballman
wrote:
> aaron.ballman added a comment.
>
> Did Richard sign off on this off-line? Also, this has caused a bot failure:
>
That was my understanding.
>
> 7:57 AM build #4390 of ninja-clang-i686-msc19-R is complete:
> Failure [failed build_clang_too
aaron.ballman added a comment.
Did Richard sign off on this off-line? Also, this has caused a bot failure:
7:57 AM build #4390 of ninja-clang-i686-msc19-R is complete:
Failure [failed build_clang_tools_1] Build details are at
http://bb.pgr.jp/builders/ninja-clang-i686-msc19-R/builds/4390 bla
hubert.reinterpretcast updated this revision to Diff 61763.
hubert.reinterpretcast added a comment.
Update to r273650 with the requested const accessor
http://reviews.llvm.org/D19770
Files:
include/llvm/Support/TrailingObjects.h
Index: include/llvm/Support/TrailingObjects.h
=
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
I think this LGTM (with the const overload), but you should poke Richard to see
what his thoughts are before committing.
Comment at: include/llvm/Support/Traili
hubert.reinterpretcast added inline comments.
Comment at: include/llvm/Support/TrailingObjects.h:353
@@ +352,3 @@
+ ///
+ /// \code{.cpp}
+ ///
aaron.ballman wrote:
> That's novel (we use it in two other places from what I can tell).
This is a documented Doxyge
aaron.ballman added inline comments.
Comment at: include/llvm/Support/TrailingObjects.h:353
@@ +352,3 @@
+ ///
+ /// \code{.cpp}
+ ///
That's novel (we use it in two other places from what I can tell).
Comment at: include/llvm/Support/Trailing
hubert.reinterpretcast added a comment.
Ping.
http://reviews.llvm.org/D19770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hubert.reinterpretcast marked 5 inline comments as done.
hubert.reinterpretcast added a comment.
Responded to all comments.
http://reviews.llvm.org/D19770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
hubert.reinterpretcast updated this revision to Diff 55820.
hubert.reinterpretcast added a comment.
Replace alias template with struct and typedef member; add usage example
http://reviews.llvm.org/D19770
Files:
include/llvm/Support/TrailingObjects.h
Index: include/llvm/Support/TrailingObject
faisalv added a comment.
Thanks for your response. I don't feel strongly about either of those issues -
especially since it seems you considered the options - and have good reasons
for choosing the alternative.
I would also favor adding in a comment an example of how users are expected to
use
hubert.reinterpretcast planned changes to this revision.
hubert.reinterpretcast added a comment.
The alias template hit a build-compiler bug: the substitution of the pack
expansion of `Counts` does not work properly. I am investigating a replacement
with a templated struct with a typedef member.
faisalv added a comment.
Thanks for running with this! =)
Comment at: include/llvm/Support/TrailingObjects.h:352
@@ +351,3 @@
+template
+using _ =
+llvm::AlignedCharArray::Alignment,
FWIW - while I see your point - the 'underscore' as a name see
hubert.reinterpretcast updated this revision to Diff 55728.
hubert.reinterpretcast added a comment.
Use AlignOf instead of AlignmentCalcHelper
Since BaseTy should be aligned properly for its trailing objects, the
use of AlignmentCalcHelper is unnecessary.
http://reviews.llvm.org/D19770
Files:
hubert.reinterpretcast added a comment.
An example of using `FixedSizeStorage` can be found in
http://reviews.llvm.org/D19771.
Comment at: include/llvm/Support/TrailingObjects.h:352
@@ +351,3 @@
+template
+using _ =
+llvm::AlignedCharArrayhttp://reviews.llvm.or
24 matches
Mail list logo
