Re: [PATCH] D19720: [find-all-symbols] Parallelize the merge step.

2016-04-29 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL268037: [find-all-symbols] Parallelize the merge step. (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D19720?vs=55577&id=55589#toc Repository: rL LLVM http://reviews.llvm.org/D1

Re: [PATCH] D19720: [find-all-symbols] Parallelize the merge step.

2016-04-29 Thread Haojian Wu via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Just see you updated code. LGTM. http://reviews.llvm.org/D19720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

Re: [PATCH] D19720: [find-all-symbols] Parallelize the merge step.

2016-04-29 Thread Haojian Wu via cfe-commits
hokein added inline comments. Comment at: include-fixer/find-all-symbols/tool/FindAllSymbolsMain.cpp:107 @@ -94,3 +106,3 @@ } llvm::raw_fd_ostream OS(OutputFile, EC, llvm::sys::fs::F_None); Don't we need to all 'Pool.wait()' to wait for all working threads

Re: [PATCH] D19720: [find-all-symbols] Parallelize the merge step.

2016-04-29 Thread Benjamin Kramer via cfe-commits
bkramer updated this revision to Diff 55577. bkramer added a comment. Drain the pool, fix typo. http://reviews.llvm.org/D19720 Files: include-fixer/find-all-symbols/tool/FindAllSymbolsMain.cpp Index: include-fixer/find-all-symbols/tool/FindAllSymbolsMain.cpp =