This revision was automatically updated to reflect the committed changes.
Closed by commit rL268919: [clang-tidy] new google-default-arguments check
(authored by hokein).
Changed prior to commit:
http://reviews.llvm.org/D19534?vs=56529&id=56569#toc
Repository:
rL LLVM
http://reviews.llvm.or
courbet added a comment.
Thanks. I don't have write access, could you please submit this for me ?
http://reviews.llvm.org/D19534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
courbet updated this revision to Diff 56529.
courbet marked an inline comment as done.
http://reviews.llvm.org/D19534
Files:
clang-tidy/google/CMakeLists.txt
clang-tidy/google/DefaultArgumentsCheck.cpp
clang-tidy/google/DefaultArgumentsCheck.h
clang-tidy/google/GoogleTidyModule.cpp
docs
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM with one nit.
Comment at: test/clang-tidy/google-default-arguments.cpp:10
@@ +9,3 @@
+ void f(int I, int J = 5);
+ // CHECK-MESSAGES: :[[@LINE-1]]:8: warning: default a
courbet added inline comments.
Comment at: clang-tidy/google/GoogleTidyModule.cpp:40
@@ -38,1 +39,3 @@
void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override {
+CheckFactories.registerCheck(
+"google-default-arguments");
hokein wro
courbet updated this revision to Diff 56000.
courbet marked 4 inline comments as done.
courbet added a comment.
Cosmetics + change error message.
http://reviews.llvm.org/D19534
Files:
clang-tidy/google/CMakeLists.txt
clang-tidy/google/DefaultArgumentsCheck.cpp
clang-tidy/google/DefaultArg
hokein added inline comments.
Comment at: clang-tidy/google/DefaultArgumentsCheck.cpp:31
@@ +30,3 @@
+ diag(MatchedDecl->getLocation(),
+ "default argument given for virtual or override method.");
+}
Usually, clang-tidy's warning message is not a sentence,
