Re: [PATCH] D19478: Remove assert mandating you can only use SPIR target with OpenCL

2016-04-27 Thread Neil Henning via cfe-commits
sheredom closed this revision. sheredom added a comment. Thanks! http://reviews.llvm.org/D19478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19478: Remove assert mandating you can only use SPIR target with OpenCL

2016-04-26 Thread Anastasia Stulova via cfe-commits
Anastasia added a comment. Committed in r267561! http://reviews.llvm.org/D19478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19478: Remove assert mandating you can only use SPIR target with OpenCL

2016-04-26 Thread Neil Henning via cfe-commits
sheredom added a comment. So we build a bunch of internal libraries in a mix of OpenCL and C++, and then link them all together to create SPIR libraries that can be fed to calls to clLinkProgram and linked against user kernels. I don't have commit writes to Clang - if the patch is ok to go coul

Re: [PATCH] D19478: Remove assert mandating you can only use SPIR target with OpenCL

2016-04-25 Thread Xiuli PAN via cfe-commits
pxli168 accepted this revision. pxli168 added a comment. LGTM. http://reviews.llvm.org/D19478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19478: Remove assert mandating you can only use SPIR target with OpenCL

2016-04-25 Thread Anastasia Stulova via cfe-commits
Anastasia added a comment. LGTM, just wondering other languages will compile to SPIR too? http://reviews.llvm.org/D19478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19478: Remove assert mandating you can only use SPIR target with OpenCL

2016-04-25 Thread Yaxun Liu via cfe-commits
yaxunl added a comment. LGTM http://reviews.llvm.org/D19478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits