Re: [PATCH] D19458: Add address space 258 to Clang documentation

2016-05-03 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL268432: Add address space 258 (X86 SS segment) to clang documentation. (authored by dlkreitz). Changed prior to commit: http://reviews.llvm.org/D19458?vs=54877&id=56056#toc Repository: rL LLVM http:

Re: [PATCH] D19458: Add address space 258 to Clang documentation

2016-04-26 Thread Michael Kuperstein via cfe-commits
mkuper added a comment. LGTM http://reviews.llvm.org/D19458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19458: Add address space 258 to Clang documentation

2016-04-25 Thread Michael LeMay via cfe-commits
mlemay-intel updated this revision to Diff 54877. mlemay-intel added a comment. Update heading. http://reviews.llvm.org/D19458 Files: docs/LanguageExtensions.rst Index: docs/LanguageExtensions.rst === --- docs/LanguageExtensions

Re: [PATCH] D19458: Add address space 258 to Clang documentation

2016-04-25 Thread Michael LeMay via cfe-commits
mlemay-intel added a comment. In http://reviews.llvm.org/D19458#410042, @mkuper wrote: > LGTM with a small nit - can you change the heading from "Memory references > off the GS segment" to something more general? Good idea! Thanks for noticing that inconsistency. http://reviews.llvm.org/D194

Re: [PATCH] D19458: Add address space 258 to Clang documentation

2016-04-24 Thread Michael Kuperstein via cfe-commits
mkuper accepted this revision. mkuper added a comment. This revision is now accepted and ready to land. LGTM with a small nit - can you change the heading from "Memory references off the GS segment" to something more general? http://reviews.llvm.org/D19458 ___