Re: [PATCH] D19382: [OpenMP] Improve mappable expressions Sema.

sfantao updated this revision to Diff 55002. sfantao marked an inline comment as done. sfantao added a comment. - Explicitelly store canonical declaration when looking for unique declarations. http://reviews.llvm.org/D19382 Files: include/clang/AST/OpenMPClause.h lib/AST/OpenMPClause.cpp

Re: [PATCH] D19382: [OpenMP] Improve mappable expressions Sema.

sfantao marked 2 inline comments as done. sfantao added a comment. Hi Alexey, Thanks for the review. Comment at: lib/AST/OpenMPClause.cpp:546 @@ +545,3 @@ + for (auto *D : Declarations) { +assert( +(!D || D->isCanonicalDecl()) && ABataev wrote: > s

Re: [PATCH] D19382: [OpenMP] Improve mappable expressions Sema.

ABataev accepted this revision. This revision is now accepted and ready to land. Comment at: lib/AST/OpenMPClause.cpp:546 @@ +545,3 @@ + for (auto *D : Declarations) { +assert( +(!D || D->isCanonicalDecl()) && sfantao wrote: > Ok, using canonical decl

Re: [PATCH] D19382: [OpenMP] Improve mappable expressions Sema.

sfantao marked an inline comment as done. Comment at: lib/AST/OpenMPClause.cpp:546 @@ +545,3 @@ + for (auto *D : Declarations) { +assert( +(!D || D->isCanonicalDecl()) && Ok, using canonical declarations now. http://reviews.llvm.org/D19382

Re: [PATCH] D19382: [OpenMP] Improve mappable expressions Sema.

sfantao updated this revision to Diff 54941. sfantao added a comment. - Use canonical declarations associated with mappable expressions. http://reviews.llvm.org/D19382 Files: include/clang/AST/OpenMPClause.h lib/AST/OpenMPClause.cpp lib/Sema/SemaOpenMP.cpp lib/Serialization/ASTReaderStm

Re: [PATCH] D19382: [OpenMP] Improve mappable expressions Sema.

ABataev added inline comments. Comment at: lib/AST/OpenMPClause.cpp:546 @@ +545,3 @@ + for (auto *D : Declarations) { +if (Cache.count(D)) + continue; I think you'd better to count and to store canonical decls rather than the decls themselves. It will r

Re: [PATCH] D19382: [OpenMP] Improve mappable expressions Sema.

sfantao added a comment. Hi Alexey, Thanks for the review! Comment at: include/clang/AST/OpenMPClause.h:2789-2797 @@ +2788,11 @@ +// \brief Expression associated with the component. +Expr *AssociatedExpression; +// \brief Declaration associated with the declaration.

Re: [PATCH] D19382: [OpenMP] Improve mappable expressions Sema.

sfantao updated this revision to Diff 54672. sfantao marked 15 inline comments as done. sfantao added a comment. - Address review comments. Fix bug in the evaluation of the unique declarations. http://reviews.llvm.org/D19382 Files: include/clang/AST/OpenMPClause.h lib/AST/OpenMPClause.cpp

Re: [PATCH] D19382: [OpenMP] Improve mappable expressions Sema.

ABataev added inline comments. Comment at: include/clang/AST/OpenMPClause.h:2789-2797 @@ +2788,11 @@ +// \brief Expression associated with the component. +Expr *AssociatedExpression; +// \brief Declaration associated with the declaration. If the component does +//