Re: [PATCH] D19327: Keep invalid function body as part of the AST

2016-06-16 Thread Olivier Goffart via cfe-commits
ogoffart abandoned this revision. ogoffart added a comment. Replaced by http://reviews.llvm.org/D19764 http://reviews.llvm.org/D19327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19327: Keep invalid function body as part of the AST

2016-05-25 Thread Olivier Goffart via cfe-commits
ogoffart added a comment. Is this better than the alternative http://reviews.llvm.org/D19764 ? http://reviews.llvm.org/D19327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19327: Keep invalid function body as part of the AST

2016-04-30 Thread Olivier Goffart via cfe-commits
ogoffart added a comment. An alternative patch is uploaded there: http://reviews.llvm.org/D19764 http://reviews.llvm.org/D19327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19327: Keep invalid function body as part of the AST

2016-04-27 Thread Olivier Goffart via cfe-commits
ogoffart added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5044-5045 @@ -5043,4 +5043,4 @@ // function template specialization, add it to the scope stack. - if (New->getDeclName() && AddToScope && - !(D.isRedeclaration() && New->isInvalidDecl())) { + if (New->get

Re: [PATCH] D19327: Keep invalid function body as part of the AST

2016-04-26 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5044-5045 @@ -5043,4 +5043,4 @@ // function template specialization, add it to the scope stack. - if (New->getDeclName() && AddToScope && - !(D.isRedeclaration() && New->isInvalidDecl())) { + if (New->getDe

Re: [PATCH] D19327: Keep invalid function body as part of the AST

2016-04-26 Thread Olivier Goffart via cfe-commits
ogoffart added a comment. Ping? http://reviews.llvm.org/D19327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits