Re: [PATCH] D19249: Fix include path in ClangTidy.cpp.

2016-04-27 Thread Stephen Hines via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL267835: Fix include path in ClangTidy.cpp. (authored by srhines). Changed prior to commit: http://reviews.llvm.org/D19249?vs=54587&id=55368#toc Repository: rL LLVM http://reviews.llvm.org/D19249 Fi

Re: [PATCH] D19249: Fix include path in ClangTidy.cpp.

2016-04-27 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Since http://reviews.llvm.org/D19393 is approved, this patch also looks fine. http://reviews.llvm.org/D19249 ___ cfe-commits mailing list cfe-com

Re: [PATCH] D19249: Fix include path in ClangTidy.cpp.

2016-04-26 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. In http://reviews.llvm.org/D19249#408437, @chh wrote: > This change depends on http://reviews.llvm.org/D19393. I'm personally fine with the solution in http://reviews.llvm.org/D1939

Re: [PATCH] D19249: Fix include path in ClangTidy.cpp.

2016-04-21 Thread Chih-Hung Hsieh via cfe-commits
chh added a comment. This change depends on http://reviews.llvm.org/D19393. http://reviews.llvm.org/D19249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19249: Fix include path in ClangTidy.cpp.

2016-04-21 Thread Chih-Hung Hsieh via cfe-commits
chh updated this revision to Diff 54587. http://reviews.llvm.org/D19249 Files: clang-tidy/ClangTidy.cpp Index: clang-tidy/ClangTidy.cpp === --- clang-tidy/ClangTidy.cpp +++ clang-tidy/ClangTidy.cpp @@ -58,7 +58,7 @@ #define GET_C

Re: [PATCH] D19249: Fix include path in ClangTidy.cpp.

2016-04-21 Thread Stephen Hines via cfe-commits
srhines added inline comments. Comment at: clang-tidy/ClangTidy.cpp:61 @@ -60,3 +60,3 @@ FULLNAME, -#include "../../../lib/StaticAnalyzer/Checkers/Checkers.inc" +#include "Checkers.inc" #undef CHECKER alexfh wrote: > As it is, the change leaves almost no conte

Re: [PATCH] D19249: Fix include path in ClangTidy.cpp.

2016-04-21 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. This revision now requires changes to proceed. Comment at: clang-tidy/ClangTidy.cpp:61 @@ -60,3 +60,3 @@ FULLNAME, -#include "../../../lib/StaticAnalyzer/Checkers/Checkers.inc" +#include "Checkers.inc" #undef CHECKER