aaron.ballman closed this revision.
aaron.ballman added a comment.
Thanks! I've commit in r267338.
http://reviews.llvm.org/D19244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Ping.
http://reviews.llvm.org/D19244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman marked 6 inline comments as done.
Comment at: lib/Sema/SemaChecking.cpp:2722
@@ -2720,1 +2721,3 @@
ParamLoc = PV->getLocation();
+ IsCRegister =
+ PV->getStorageClass() == SC_Register && !getLangOpts().CPlusPlus;
That makes sense
aaron.ballman updated this revision to Diff 54201.
aaron.ballman added a comment.
Addressed review comments:
- Allow the register keyword for C++ code
- Reword the diagnostic to be a bit more clear
- Moved the varargs.cpp test case from Sema to SemaCXX
http://reviews.llvm.org/D19244
Files:
i
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7417-7421
@@ -7416,4 +7416,7 @@
InGroup;
-def warn_va_start_of_reference_type_is_undefined : Warning<
- "'va_start' has undefined behavior with reference types">, InGroup;
+def warn_va_start_t
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7417-7421
@@ -7416,4 +7416,7 @@
InGroup;
-def warn_va_start_of_reference_type_is_undefined : Warning<
- "'va_start' has undefined behavior with reference types">, InGroup;
+def warn_va_
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7417-7421
@@ -7416,4 +7416,7 @@
InGroup;
-def warn_va_start_of_reference_type_is_undefined : Warning<
- "'va_start' has undefined behavior with reference types">, InGroup;
+def warn_va_start_t
