Re: [PATCH] D19003: Set C99 as default C Standard for PS4 target

2016-04-27 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL267772: Set the default C standard to C99 when targeting the PS4. (authored by ssrivastava). Changed prior to commit: http://reviews.llvm.org/D19003?vs=54956&id=55299#toc Repository: rL LLVM http://

Re: [PATCH] D19003: Set C99 as default C Standard for PS4 target

2016-04-26 Thread Paul Robinson via cfe-commits
probinson accepted this revision. probinson added a reviewer: probinson. probinson added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D19003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

Re: [PATCH] D19003: Set C99 as default C Standard for PS4 target

2016-04-25 Thread Douglas Yung via cfe-commits
dyung updated this revision to Diff 54956. dyung added a comment. Updated diff to fix up the comments based on Paul's feedback. Also tightened up one of the #if blocks to not include something that did not require C11. http://reviews.llvm.org/D19003 Files: include/clang/Frontend/CompilerInvo

Re: [PATCH] D19003: Set C99 as default C Standard for PS4 target

2016-04-20 Thread Paul Robinson via cfe-commits
probinson added a subscriber: probinson. Comment at: test/Sema/attr-deprecated.c:124 @@ -123,1 +123,3 @@ +// This note requires C11. +#if __STDC_VERSION__ > 199901L Just the note? Or the warning? Comment at: test/Sema/nullability.c:30 @@ -25,1

Re: [PATCH] D19003: Set C99 as default C Standard for PS4 target

2016-04-20 Thread Douglas Yung via cfe-commits
dyung added a comment. Ping http://reviews.llvm.org/D19003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits