Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

2016-04-28 Thread silviu.bara...@arm.com via cfe-commits
sbaranga added a comment. Thanks, r267869! -Silviu http://reviews.llvm.org/D18963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

2016-04-27 Thread Renato Golin via cfe-commits
rengolin added a comment. LGTM! Thanks! http://reviews.llvm.org/D18963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

2016-04-26 Thread silviu.bara...@arm.com via cfe-commits
sbaranga added inline comments. Comment at: test/Sema/arm_vfma.c:1 @@ -1,2 +1,2 @@ -// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple thumbv7-none-eabi -target-feature +neon -target-feature +vfp4 -fsyntax-

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

2016-04-26 Thread silviu.bara...@arm.com via cfe-commits
sbaranga updated this revision to Diff 55018. sbaranga added a comment. Address the latest review comments (which means rolling back to the last change). http://reviews.llvm.org/D18963 Files: lib/Basic/Targets.cpp test/CodeGen/arm-neon-fma.c test/Preprocessor/arm-acle-6.5.c test/Sema/a

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

2016-04-26 Thread silviu.bara...@arm.com via cfe-commits
sbaranga added inline comments. Comment at: lib/Basic/Targets.cpp:4710 @@ -4709,1 +4709,3 @@ const std::vector &FeaturesVec) const override { +if (CPU == "") + CPU = "generic"; rengolin wrote: > This change is unrelated and may bring sid

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

2016-04-26 Thread Renato Golin via cfe-commits
rengolin added inline comments. Comment at: lib/Basic/Targets.cpp:4710 @@ -4709,1 +4709,3 @@ const std::vector &FeaturesVec) const override { +if (CPU == "") + CPU = "generic"; This change is unrelated and may bring side effects into cla

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

2016-04-22 Thread silviu.bara...@arm.com via cfe-commits
sbaranga added a comment. A gentle ping? Cheers, Silviu http://reviews.llvm.org/D18963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

2016-04-12 Thread silviu.bara...@arm.com via cfe-commits
sbaranga added a comment. I've updated the patch to fix the defaults when the cpu is not specified. Renato, Tim, could you have a look at this again please? Thanks, Silviu http://reviews.llvm.org/D18963 ___ cfe-commits mailing list cfe-commits@lis

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

2016-04-12 Thread silviu.bara...@arm.com via cfe-commits
sbaranga updated this revision to Diff 53409. sbaranga added a comment. If no cpu has been passed to the command line, use the generic cpu when selecting features/FPU, instead of using an empty string (which is not recognized by the TargetParser). http://reviews.llvm.org/D18963 Files: lib/Ba

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

2016-04-12 Thread silviu.bara...@arm.com via cfe-commits
sbaranga added inline comments. Comment at: test/Sema/arm_vfma.c:1 @@ -1,2 +1,2 @@ -// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon -target-feature +vfp4 -fsyn

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

2016-04-11 Thread Tim Northover via cfe-commits
t.p.northover added inline comments. Comment at: test/Sema/arm_vfma.c:1 @@ -1,2 +1,2 @@ -// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon -target-feature +vfp4

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

2016-04-11 Thread Renato Golin via cfe-commits
rengolin added inline comments. Comment at: test/Sema/arm_vfma.c:1 @@ -1,2 +1,2 @@ -// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon -target-feature +vfp4 -fsyn

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

2016-04-11 Thread Tim Northover via cfe-commits
t.p.northover added inline comments. Comment at: test/Sema/arm_vfma.c:1 @@ -1,2 +1,2 @@ -// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple thumbv7s-apple-ios7.0 -target-feature +neon -target-feature +vfp4

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

2016-04-11 Thread Renato Golin via cfe-commits
rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. LGTM. Thanks! http://reviews.llvm.org/D18963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/li

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

2016-04-11 Thread silviu.bara...@arm.com via cfe-commits
sbaranga updated this revision to Diff 53254. sbaranga added a comment. Apply review comments from Renato: - simplify condition for enabling __ARM_FEATURE_FMA - use cortex-a7 instead of cortex-a8 for testing since this is a real use case. http://reviews.llvm.org/D18963 Files: lib/Basic/Targe

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

2016-04-11 Thread silviu.bara...@arm.com via cfe-commits
sbaranga added inline comments. Comment at: lib/Basic/Targets.cpp:4931 @@ -4931,1 +4930,3 @@ +if (ArchVersion >= 7 && (CPUProfile != "M" || CPUAttr == "7EM") && +(FPU & VFP4FPU)) Builder.defineMacro("__ARM_FEATURE_FMA", "1"); rengolin wrote: > I

Re: [PATCH] D18963: PR27216: Only define __ARM_FEATURE_FMA when the target has VFPv4

2016-04-11 Thread Renato Golin via cfe-commits
rengolin added a reviewer: rengolin. Comment at: lib/Basic/Targets.cpp:4931 @@ -4931,1 +4930,3 @@ +if (ArchVersion >= 7 && (CPUProfile != "M" || CPUAttr == "7EM") && +(FPU & VFP4FPU)) Builder.defineMacro("__ARM_FEATURE_FMA", "1"); I think just t