etienneb updated this revision to Diff 52924.
etienneb marked an inline comment as done.
etienneb added a comment.
fix nits.
http://reviews.llvm.org/D18833
Files:
clang-tidy/misc/MisplacedWideningCastCheck.cpp
Index: clang-tidy/misc/MisplacedWideningCastCheck.cpp
alexfh added a comment.
Missed a couple of nits.
Comment at: clang-tidy/misc/MisplacedWideningCastCheck.cpp:98
@@ -96,40 +97,3 @@
-static llvm::SmallDenseMap createRelativeIntSizesMap() {
- llvm::SmallDenseMap Result;
- Result[BuiltinType::UChar] = 1;
- Result[BuiltinType::
etienneb updated this revision to Diff 52921.
etienneb added a comment.
nits, lower case names.
http://reviews.llvm.org/D18833
Files:
clang-tidy/misc/MisplacedWideningCastCheck.cpp
Index: clang-tidy/misc/MisplacedWideningCastCheck.cpp
=
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D18833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
etienneb updated this revision to Diff 52919.
etienneb added a comment.
alexfh comments.
http://reviews.llvm.org/D18833
Files:
clang-tidy/misc/MisplacedWideningCastCheck.cpp
Index: clang-tidy/misc/MisplacedWideningCastCheck.cpp
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Formatting is broken. `clang-format -style=file`, please.
http://reviews.llvm.org/D18833
___
cfe-commits mailing list
cfe-commits@lists
