Re: [PATCH] D18776: NFC: make AtomicOrdering an enum class

2016-04-06 Thread JF Bastien via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL265569: NFC: make AtomicOrdering an enum class (authored by jfb). Changed prior to commit: http://reviews.llvm.org/D18776?vs=52637&id=52820#toc Repository: rL LLVM http://reviews.llvm.org/D18776 Fi

Re: [PATCH] D18776: NFC: make AtomicOrdering an enum class

2016-04-06 Thread James Y Knight via cfe-commits
jyknight accepted this revision. jyknight added a comment. BTW, this change doesn't actually depend on the LLVM change; it could be committed first, as a "normal" enum puts its members both inside the enum name's scope and outside. http://reviews.llvm.org/D18776

Re: [PATCH] D18776: NFC: make AtomicOrdering an enum class

2016-04-04 Thread Richard Smith via cfe-commits
rsmith added a subscriber: rsmith. rsmith accepted this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision is now accepted and ready to land. LGTM. Post-commit review is fine for changes like this that mechanically update Clang to match LLVM API changes. http://rev