Re: [PATCH] D18768: Refactoring attribute subject diagnostics

2016-04-22 Thread Richard Smith via cfe-commits
rsmith added a comment. I think this is a reasonable direction. I'd like to see some kind of %list form added to our diagnostics system, but I don't mind whether that happens before or after this change. (I'd also prefer to use singular forms in the various subject names, but that seems to cre

Re: [PATCH] D18768: Refactoring attribute subject diagnostics

2016-04-22 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. Ping http://reviews.llvm.org/D18768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits