Re: [PATCH] D18717: [Clang-tidy] Improve checks documentation consistency

2016-04-01 Thread Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL265205: [Clang-tidy] Improve checks documentation consistency. (authored by eugenezelenko). Changed prior to commit: http://reviews.llvm.org/D18717?vs=52441&id=52451#toc Repository: rL LLVM http://r

Re: [PATCH] D18717: [Clang-tidy] Improve checks documentation consistency

2016-04-01 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a comment. In http://reviews.llvm.org/D18717#390151, @alexfh wrote: > Also, could you, please, next time generate diffs with full context as > documented in > http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface > (or use arcanist, which does thi

Re: [PATCH] D18717: [Clang-tidy] Improve checks documentation consistency

2016-04-01 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Also, could you, please, next time generate diffs with full context as documented in http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface (or use arcanist, which does this automatically)? This sometimes (not in this case) saves reviewers manua

Re: [PATCH] D18717: [Clang-tidy] Improve checks documentation consistency

2016-04-01 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Awesome! Thanks! Repository: rL LLVM http://reviews.llvm.org/D18717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.